Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates for Mypy 1.6 #1740

Merged
merged 3 commits into from
Oct 24, 2023
Merged

Updates for Mypy 1.6 #1740

merged 3 commits into from
Oct 24, 2023

Conversation

mattwthompson
Copy link
Member

@mattwthompson mattwthompson commented Oct 11, 2023 •
edited
Loading

@codecov
Copy link

codecov bot commented Oct 11, 2023 •
edited
Loading

Codecov Report

Merging #1740 (f96d210) into main (d296ade) will decrease coverage by 0.02%.
Report is 6 commits behind head on main.
The diff coverage is 100.00%.

❗ Current head f96d210 differs from pull request most recent head ba68c28. Consider uploading reports for the commit ba68c28 to get more accurate results

Additional details and impacted files

@mattwthompson mattwthompson marked this pull request as ready for review October 11, 2023 15:11
@mattwthompson mattwthompson changed the title Scattered updated for Mypy 1.6 Updates for Mypy 1.6 Oct 13, 2023
j-wags
j-wags approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@j-wags j-wags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The examples CI failure is unrelated. Thanks for fixing this @mattwthompson! I'll update the releasenotes and merge.

@j-wags j-wags merged commit 7c1bb80 into main Oct 24, 2023
1 of 9 checks passed
@j-wags j-wags deleted the mypy-1.6 branch October 24, 2023 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-wags j-wags j-wags approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattwthompson @j-wags